Skip to content

Commit

Permalink
chore(ci): ignore interface new method findings (googleapis#854)
Browse files Browse the repository at this point in the history
  • Loading branch information
noahdietz committed Jul 12, 2022
1 parent e2551ce commit 6d432b5
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion .github/workflows/apidiff.yaml
Expand Up @@ -57,7 +57,11 @@ jobs:
with:
name: pkg.main
- name: Compare regenerated code to baseline
run: apidiff -incompatible pkg.main google.golang.org/genproto/${{ matrix.changed }} > diff.txt && cat diff.txt && ! [ -s diff.txt ]
# Ignore findings precipitated by adding a method to an interface - it is a non-issue for this repo.
run: |
apidiff -incompatible pkg.main google.golang.org/genproto/${{ matrix.changed }} > diff.txt
sed -i '/: added/d' ./diff.txt
cat diff.txt && ! [ -s diff.txt ]
- name: Add breaking change label
if: ${{ failure() && !github.event.pull_request.head.repo.fork }}
uses: actions/github-script@v6
Expand Down

0 comments on commit 6d432b5

Please sign in to comment.