Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) dockerize shellharden #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

(feat) dockerize shellharden #41

wants to merge 1 commit into from

Conversation

vladdoster
Copy link

Enables a user to run shellharden in a Docker
container.

  • Add Dockerfile & entrypoint
  • Update README.md
    • Add Docker usage
    • Wrap lines to make it easier to read from CLI
    • Correct misc. grammar & punctuation

I did this so I can use it in a CI/CD pipeline, but thought
it might be worth contributing back. If you want, I can publish
it to docker hub before you accept this PR.

Thanks for such a great tool!

Signed-off-by: Vladislav Doster mvdoster@gmail.com

Enables a user to run shellharden in a Docker
container.

- Add Dockerfile & entrypoint
= Update README.md
    - Add Docker usage
    - Wrap lines to make it easier to read from CLI
    - Correct misc. grammar & punctuation

I did this so I can use it in a CI/CD pipeline, but thought
it might be worth contributing back. If you want, I can publish
to dockerhub before you accept this PR.

Thanks for such a great tool!

Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
@vladdoster
Copy link
Author

@anordal Could I get a review, please?

@anordal
Copy link
Owner

anordal commented Apr 15, 2021

Ok, I've tried this out, and the default image is good.

But this is a bit niche. Can we have this in a "docker" subdirectory, with a separate readme?

Note that I used to have a docker recipe (7bedf28), but removed it because I thought precompiled binaries would solve some of the need (df5ff65).

The other changes to the readme are also fine, but I would appreciate a separate commit.

But what's the use case for the alpine based image? The logic about maybe executing something if it exists in $PATH does not aspire to safe programming. As for the details, it seems to be missing a chmod +x /init and the default command is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants