Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate html stats #158

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

aaditkamat
Copy link
Contributor

Closes #157

Aadit Kamat added 8 commits January 1, 2021 18:17
Signed-off-by: Aadit Kamat <aadit.k12@gmail.com>
Signed-off-by: Aadit Kamat <aadit.k12@gmail.com>
Signed-off-by: Aadit Kamat <aadit.k12@gmail.com>
Signed-off-by: Aadit Kamat <aadit.k12@gmail.com>
Signed-off-by: Aadit Kamat <aadit.k12@gmail.com>
Signed-off-by: Aadit Kamat <aadit.k12@gmail.com>
@pseusys
Copy link
Collaborator

pseusys commented Jan 14, 2023

Could you please provide us with motivation behind this PR?
The original purpose of this action is altering user README.md file, that uses markdown syntax, not HTML. Why should we mix these two?
Maybe we shoud add possibility to build output of this action with both markdown and html (separate files) later instead?

@aaditkamat
Copy link
Contributor Author

Hi @pseusys, I created issue #157 to explain the rationale behind the PR. Please feel free to have a look at that. I learned how to add sections using GFM later, so the changes made in this PR are optional. You can close the PR if you feel the changes aren't needed.

@pseusys
Copy link
Collaborator

pseusys commented Jan 15, 2023

So in the end you were able to achieve what you wanted using markdown syntax, weren't you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEAT: Generate stats in HTML
2 participants