Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use node to run eslc binary #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dead-claudia
Copy link
Contributor

@anko

Step 1 for making this buildable in Windows. Followup to #40.

Step 1 for making this buildable in Windows.
@anko anko mentioned this pull request Jan 2, 2016
4 tasks
@anko
Copy link
Owner

anko commented Jan 2, 2016

I'd prefer merging the builds-on-Windows feature all at once, since it's only really a feature when it's all together. Until then, this just slightly harms readability on other platforms. Created #44 to track necessary bits.

@dead-claudia
Copy link
Contributor Author

Go ahead and cherry pick these locally if you'd prefer.

On Sat, Jan 2, 2016, 13:40 An notifications@github.com wrote:

I'd prefer merging the builds-on-Windows feature all at once, since it's
only really a feature when it's all together. Until then, this just
slightly harms readability on other platforms. Created #44
#44 to track necessary bits.


Reply to this email directly or view it on GitHub
#43 (comment).

@dead-claudia
Copy link
Contributor Author

Closing, as per @anko's comment. No point in keeping this open any longer.

@dead-claudia
Copy link
Contributor Author

Actually, I'm reopening this.

@dead-claudia dead-claudia reopened this Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants