Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ TWEAK: improve delay expression #1508

Merged
merged 2 commits into from
Apr 21, 2022
Merged

✨ TWEAK: improve delay expression #1508

merged 2 commits into from
Apr 21, 2022

Conversation

warengonzaga
Copy link
Member

Closing #1507 replace the delay expression from s to x
Update also the documentation regarding this change.

@warengonzaga warengonzaga mentioned this pull request Mar 18, 2022
Open
eltonmesquita
eltonmesquita requested changes Apr 19, 2022
View reviewed changes
Copy link
Collaborator

@eltonmesquita eltonmesquita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments to add support for the old way of doing it. Nice work mate 🙌!

animate.css Show resolved Hide resolved
animate.css Show resolved Hide resolved
animate.css Show resolved Hide resolved
animate.css Show resolved Hide resolved
animate.css Show resolved Hide resolved
docsSource/sections/02-utilities.md Show resolved Hide resolved
@eltonmesquita eltonmesquita changed the base branch from main to v5 April 20, 2022 09:01
@warengonzaga
Copy link
Member Author

Hey @eltonmesquita, added support to old versions. Updated the docs too.

eltonmesquita
eltonmesquita approved these changes Apr 21, 2022
View reviewed changes
Copy link
Collaborator

@eltonmesquita eltonmesquita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Thanks for the changes. I'll get this merged into the v5 branch so we can get it live in the next major version 🎉

@eltonmesquita eltonmesquita merged commit e6de97a into animate-css:v5 Apr 21, 2022
@warengonzaga warengonzaga deleted the tweak/improve-delay-class branch April 21, 2022 08:52
@warengonzaga
Copy link
Member Author

Nice one! Thanks for the changes. I'll get this merged into the v5 branch so we can get it live in the next major version 🎉

Excited to launch the v5! I'll work on other improvements ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eltonmesquita eltonmesquita eltonmesquita approved these changes

Assignees
No one assigned
Labels
v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@warengonzaga @eltonmesquita