feat: generate the import declaration for the completion item code ac… #2031
Conversation
ivanwonder
force-pushed
the
generate-import-for-autocompletion
branch
3 times, most recently
from
d057ecd
to
be1a229
Compare
|
Blocked by PR |
…tions In the completion item, the `additionalTextEdits` can only be included the changes about the current file, the other changes should be inserted by the vscode command. For example, when the user selects a component in an HTML file, the extension inserts the selector in the HTML file and auto-generates the import declaration in the TS file.
ivanwonder
force-pushed
the
generate-import-for-autocompletion
branch
from
be1a229
to
6950674
Compare
|
@ivanwonder Looks like the CI is failing, due to the new test: |
dylhunn
added
cleanup
| 'range': {'start': {'line': 11, 'character': 11}, 'end': {'line': 15, 'character': 1}} | ||
| }]); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Hi,
Does this support adding auto-imports for default exported components?
Adding a test for that would also be great.
There was a problem hiding this comment.
This PR just reuses the work of code action, with no bug fix. I will put it on my to-do list and look into it.
The two new tests depend on the code of the language service PR. I remember there was a snapshot version for every PR before. I want to update the |
template-in-html.movtemplate-in-ts.movNow the format is not perfect. For example, when the 
|
…tions
In the completion item, the
additionalTextEditscan only be included the changes about the current file, the other changes should be inserted by the vscode command.For example, when the user selects a component in an HTML file, the extension inserts the selector in the HTML file and auto-generates the import declaration in the TS file.