Added error handling for @angular/language-service calls #138

DBosley · 2017-08-03T22:22:54Z

This PR should fix #128 for any errors thrown by the following @angular/language-service calls:

getHoverAt
getDefinitionAt
getTemplateReferences
getDiagnostics
getCompletionsAt

chuckjaz · 2017-08-04T00:18:09Z

server/src/editorServices.ts

+    } catch (error) {
+        logger.msg(
+            `Error for ${name}:\n` +
+            `    ${error}`


The stack is useful to diagnose problems. Consider changing this to error.stack || error

chuckjaz · 2017-08-04T00:20:54Z

Let me know if you want to take my recommendation. I will commit this before the release as well.

DBosley · 2017-08-04T00:52:05Z

@chuckjaz I'll toss that in there. One minute.

Adding try/catch around @angular/language-service calls to avoid output window opening on its own.

DBosley · 2017-08-04T01:53:20Z

angular-automatic-lock-bot · 2020-02-14T16:03:46Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

_{This action has been performed automatically by a bot.}

This was referenced Aug 3, 2017

Output Window gets opened when I type #128

Closed

Dependencies updated #136

Merged

chuckjaz approved these changes Aug 4, 2017

View reviewed changes

Fixes #128 for all errors

9682e58

Adding try/catch around @angular/language-service calls to avoid output window opening on its own.

Merge branch 'master' into error-handling

53633be

chuckjaz merged commit 88f2bd1 into angular:master Aug 4, 2017

angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 14, 2020

Provide feedback