-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Closed
Labels
P2The issue is important to a large percentage of users, with a workaroundThe issue is important to a large percentage of users, with a workaroundarea: material/buttonfeatureThis issue represents a new feature or feature request rather than a bug or bug fixThis issue represents a new feature or feature request rather than a bug or bug fix
Description
Tasks
- Scaffold empty classes, assets, demo, build config, etc.
- Stub existing component API
- Hook up MDC foundation and adapter
- Add remaining features on top of MDC implementation
- Test dark theme
- Test RTL
- Test with screen-readers
- Copy existing unit tests and ensure they all pass
- Copy existing e2e tests and ensure they all pass (if any)
- Verify SSR support in
universal-app/ - Verify no size regression
- Create test harness
- Create schematics for migration
- Create user documentation
Additional notes
- Consider supporting button[mat-outlined-button]
- Should each button type have a unique top level class? e.g. mdc-mat-icon-button
- Consider if we want to add a "appearance/type" input to button, similar to form field (outline/stroked, flat, raised)
Breaking changes
Known issues & visual differences
- Disabled FAB does not look disabled
- Anchor button does not look disabled
- No focused state
- Icon buttons are not colored by theme
- Missing JSDoc comments on some exported symbols
GabDug and ArsalanSavandDaSchTour
Metadata
Metadata
Assignees
Labels
P2The issue is important to a large percentage of users, with a workaroundThe issue is important to a large percentage of users, with a workaroundarea: material/buttonfeatureThis issue represents a new feature or feature request rather than a bug or bug fixThis issue represents a new feature or feature request rather than a bug or bug fix