Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating callable functions documentation #3277

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Oct 14, 2022

  1. Updating callable functions documentation

    In `app.module.ts` I put in commented out lines anticipating AngularFire 7. When AngularFire 7 is available for callable functions we can easily update the documentation with a few clicks.
    
    I also put in two lines showing how to run your functions in the Firebase emulator. I clearly indicated how to comment out these lines to run your functions in the cloud.
    
    I made an HTML view to show how to handle user input. Also I added a second set of curly brackets to `{{ data$ | async }}`. This is necessary to make the code run without throwing errors.
    
    In `app.component.ts` I put in lines anticipating AngularFire 7.
    
    I moved the template to an HTML view. 
    
    I added a variable `data$` to handle the data returned from the cloud function. I added `this` to `fns.httpsCallable('my-fn-name');`. These changes are necessary to make the code run without throwing errors.
    
    I changed `fns` to `functions` for readability.
    
    I made two functions, one that executes on page load and the user executes on user input.
    
    I put in the `index.js` file showing the cloud functions. The old documentation was confusing as to what data went from Angular to the cloud function and what data was returned from the cloud function. Showing the `index.js` functions clarifies this.
    
    I've written a longer tutorial at https://github.com/tdkehoe/Firebase-Cloud-Functions-with-Angular/blob/main/README.md.
    
    When can we expect to use AngularFire 7 with callable functions?
    tdkehoe committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    e9200a7 View commit details
    Browse the repository at this point in the history