Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README.md #3241

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Updated README.md #3241

wants to merge 5 commits into from

Conversation

estrellajm
Copy link

@estrellajm estrellajm commented Jun 27, 2022

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? (yes/no; required) No, ran into issues as it could not find several modules in '@angular/fire/schematics'. What node version should I should I be using? I had v16.15.1, but it didn't let me install. ng-package error.

Description

Updated README.md to include information on the environment file & provider section.

Code sample

I was getting the following error:

NullInjectorError: No provider for InjectionToken angularfire2.app.options!

Which was resolved by simply adding the FIREBASE_OPTIONS into the provider. Ref https://stackoverflow.com/questions/71431785/angular-fire-no-provider-for-injectiontoken-angularfire2-app-options
Added instructions to update the environment file.
Upgraded AppComponent constructor in order to address errors.
removed env config file info as this is auto populated
Copy link

@ezequieltejada ezequieltejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct for me.

Copy link

@lazmeister lazmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants