Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(forms): Add JSDoc content for typed forms. #45841

Closed
wants to merge 1 commit into from

Conversation

dylhunn
Copy link
Contributor

@dylhunn dylhunn commented May 2, 2022

Update the JSDoc on forms model classes with more specific information about the new types.

(public-api review is spurious; no actual API changes were made.)

Issue: #13721

@dylhunn dylhunn added comp: docs area: forms target: major This PR is targeted for the next major release forms: Controls API Issues related to AbstractControl, FormControl, FormGroup, FormArray. cross-cutting: types labels May 2, 2022
@dylhunn dylhunn requested a review from AndrewKushnir May 2, 2022 17:33
@ngbot ngbot bot modified the milestone: Backlog May 2, 2022
@dylhunn dylhunn marked this pull request as ready for review May 2, 2022 17:34
@dylhunn dylhunn modified the milestones: Backlog, v14-candidates May 2, 2022
Update the JSDoc on forms model classes with more specific information about the new types.
Copy link
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@dylhunn
Copy link
Contributor Author

dylhunn commented May 2, 2022

merge-assistance: this is not a real public-api change; it's just docs that happen to trigger a minor update to one of the golden files.

@dylhunn dylhunn added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label May 2, 2022
@ngbot ngbot bot added the action: merge The PR is ready for merge by the caretaker label May 2, 2022
@ngbot
Copy link

ngbot bot commented May 2, 2022

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "ci/circleci: test_win" is failing
    pending status "google3" is pending
    pending status "pullapprove" is pending
    pending 3 pending code reviews

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@dylhunn
Copy link
Contributor Author

dylhunn commented May 2, 2022

This PR was merged into the repository by commit fce5063.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 10, 2022
@dylhunn dylhunn deleted the tf-docs branch November 30, 2022 20:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: forms cross-cutting: types forms: Controls API Issues related to AbstractControl, FormControl, FormGroup, FormArray. forms: strictly typed merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants