fix(docs-infra): add swap to web fonts so downloading does not block… #35352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
added
action: review
|
You can preview 4d879e9 at https://pr35352-4d879e9.ngbuilds.io/. |
gkalpak
requested changes
Feb 14, 2020
There was a problem hiding this comment.
Thx, @ajitsinghkaler 👍
Please change the commit message to have fix as scope: fix(docs-infra): ...
aio/src/index.html
Outdated
| <link rel="stylesheet" href="https://fonts.googleapis.com/icon?family=Material+Icons"> | ||
| <link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Roboto:300,400,500&display=swap"> | ||
| <link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Droid+Sans+Mono&display=swap"> | ||
| <link rel="stylesheet" href="https://fonts.googleapis.com/icon?family=Material+Icons&display=swap"> |
There was a problem hiding this comment.
Since this is an icon font, I don't think it makes sense to show a fallback font.
gkalpak
added
action: cleanup
ajitsinghkaler
force-pushed
the
google-font
branch
2 times, most recently
from
c666a92
to
26a452a
Compare
ajitsinghkaler
changed the title
|
You can preview 26a452a at https://pr35352-26a452a.ngbuilds.io/. |
|
@gkalpak made the changes please have a look |
gkalpak
requested changes
Feb 18, 2020
aio/src/index.html
Outdated
| <link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Roboto:300,400,500"> | ||
| <link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Droid+Sans+Mono"> | ||
| <link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Roboto:300,400,500&display=swap"> | ||
| <link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Droid+Sans+Mono&display=swap"> | ||
| <link rel="stylesheet" href="https://fonts.googleapis.com/icon?family=Material+Icons"> |
There was a problem hiding this comment.
Actually, based on this thread (and mentioned resources), I think display: block is the appropriate value for icon fonts (which will also make LightHouse happy):
Suggested change
| <link rel="stylesheet" href="https://fonts.googleapis.com/icon?family=Material+Icons"> | |
| <link rel="stylesheet" href="https://fonts.googleapis.com/icon?family=Material+Icons&display=block"> |
…ock rendering Light house was reporting that 'Ensure text remains visible during webfont load' solution to this problem was adding &swap to the end of web fonts this leads to our first text showing before web-font download and improves the performance of site link to article: https://web.dev/font-display/\?utm_source\=lighthouse\&utm_medium\=lr
ajitsinghkaler
force-pushed
the
google-font
branch
from
26a452a
to
5ba991f
Compare
|
You can preview 5ba991f at https://pr35352-5ba991f.ngbuilds.io/. |
gkalpak
added
action: merge
alxhub
pushed a commit
that referenced
this pull request
Feb 18, 2020
…ock rendering (#35352) Light house was reporting that 'Ensure text remains visible during webfont load' solution to this problem was adding &swap to the end of web fonts this leads to our first text showing before web-font download and improves the performance of site link to article: https://web.dev/font-display/\?utm_source\=lighthouse\&utm_medium\=lr PR Close #35352
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… rendering
Light house was reporting that 'Ensure text remains visible during webfont load' solution to this was adding & swap to the end o web fonts this leds to our first text showing before web-font download and improves the performance of out site link to article: https://web.dev/font-display/\?utm_source\=lighthouse\&utm_medium\=lr
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Web fonts block rendering.
Issue Number: N/A
What is the new behavior?
Web fonts won't block rendering while downloading.
Does this PR introduce a breaking change?
Other information