Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): remove i18n markup even if no translations #17999

Merged
merged 1 commit into from
Jul 7, 2017

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jul 7, 2017

Fixes #11042

Supersedes #17959 (failing circleCI)

I approved the original PR

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@vicb vicb added area: core Issues related to the framework runtime area: i18n labels Jul 7, 2017
@mary-poppins
Copy link

You can preview bc4dfc5 at https://pr17999-bc4dfc5.ngbuilds.io/.

@vicb vicb added the action: merge The PR is ready for merge by the caretaker label Jul 7, 2017
@jasonaden jasonaden merged commit 9c3386b into angular:master Jul 7, 2017
@vicb
Copy link
Contributor Author

vicb commented Jul 8, 2017

@ocombe Sorry that the commit got attributed to me - it's how the GH merge button work (it would take the PR author instead of the commit author), a "feature" according to GH support.

@vicb vicb deleted the gh-17959 branch July 8, 2017 00:52
jasonaden pushed a commit to jasonaden/angular that referenced this pull request Jul 8, 2017
jasonaden pushed a commit to jasonaden/angular that referenced this pull request Jul 8, 2017
jasonaden pushed a commit to jasonaden/angular that referenced this pull request Jul 8, 2017
@actra-gschuster
Copy link

actra-gschuster commented Jul 19, 2017

In general I understand the motivation for this "fix".
But in my case it destroys the functionality of inlining all translations at compile-time because the parser throws away the attributes too early.
This should definitely be configurable if one wants to throw away the attributes.

Use case: @actra-development-oss/ng-i18n-aot-loader
See #16477 (comment) for further details.

asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@ocombe ocombe mentioned this pull request Jan 25, 2018
20 tasks
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime area: i18n cla: no
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove i18n tags from compiled angular templates
6 participants