Maximum call stack size exceeded after updating `@angular/compiler-cli`

[michalSolarz]

🐞 Bug report

Command (mark with an x)

• new
• build
• serve
• test
• e2e
• generate
• add
• update
• lint
• xi18n
• run
• config
• help
• version
• doc

Is this a regression?

Yes, the previous version in which this bug was not present was: 9.0.2

Description

After updating `@angular/compiler-cli 9.0.3` during ng serve I receive following error: `ERROR in Maximum call stack size exceeded`

🔬 Minimal Reproduction

🔥 Exception or Error

ERROR in Maximum call stack size exceeded

🌍 Your Environment

ng version

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/
    

Angular CLI: 9.0.3
Node: 12.13.1
OS: linux x64

Angular: 9.0.3
... animations, cli, common, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router
Ivy Workspace: Yes

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.900.3
@angular-devkit/build-angular     0.900.3
@angular-devkit/build-optimizer   0.900.3
@angular-devkit/build-webpack     0.900.3
@angular-devkit/core              9.0.3
@angular-devkit/schematics        9.0.3
@angular/cdk                      9.1.0
@angular/compiler                 9.0.2
@angular/material                 9.1.0
@ngtools/webpack                  9.0.3
@schematics/angular               9.0.3
@schematics/update                0.900.3
rxjs                              6.5.4
typescript                        3.7.5
webpack                           4.41.2

Anything else relevant?

[petebacondarwin]

Some other people reported that deleting their node_modules and re-installing got rid of this error... can you try that?

[YarnSphere]

I was getting this error when running ngcc during postinstall. Removing node_modules fixed that.

However, I can confirm that the error persists when running ng serve or ng build.

I can also confirm that the issue does not occur with Ivy disabled ("enableIvy": false) nor with version 9.0.2.

[PMoransais]

Reported error as #35721 now closed
Since then I downgraded to 9.0.2 and reinstalled node -modules-> the bug is present in 9.0.2 - not a regression for me.
Reinstalled 9.0.3 and deleted and reinstalled node-modules - > same error
There is a repro with #35721

In all cases for me ng serve and ng build work. ng build --prod does not work memory error in terser

[michalSolarz]

Some other people reported that deleting their node_modules and re-installing got rid of this error... can you try that?

@petebacondarwin I don't receive that error any more after removing node_modules. I've had similar issue during building ng library when typescript files resided in directory with identical name. Maybe its some clue?

[cyrilletuzi]

Same as #17115 and angular/angular#35709

I had to delete node_modules and reinstall (with npm ci) to fix the error, which was happening with all the third-party libs except Material.

But while the error is gone, during Ivy compilation on first serve/build, my computer heated as hell (which never happen usually, I have a very recent Macbook Pro). I had to close a process in Monitor Activity to make the heat stop. So it's seems there is a memory leak somewhere.

ng version:

Angular CLI: 9.0.4
Node: 12.16.1
OS: darwin x64

Angular: 9.0.4
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, localize, platform-browser
... platform-browser-dynamic, router, service-worker
Ivy Workspace: Yes

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.900.4
@angular-devkit/build-angular      0.900.4
@angular-devkit/build-ng-packagr   0.900.4
@angular-devkit/build-optimizer    0.900.4
@angular-devkit/build-webpack      0.900.4
@angular-devkit/core               9.0.4
@angular-devkit/schematics         9.0.4
@angular/cdk                       9.1.0
@angular/material                  9.1.0
@ngtools/webpack                   9.0.4
@schematics/angular                9.0.4
@schematics/update                 0.900.4
ng-packagr                         9.0.0
rxjs                               6.5.4
typescript                         3.7.5
webpack                            4.41.2

It's not happening with Angular 9.0.2 and Angular CLI 9.0.4. So the error is on the Angular side.

ng version where it's working:

Angular CLI: 9.0.4
Node: 12.16.1
OS: darwin x64

Angular: 9.0.2
... animations, common, compiler, compiler-cli, core, forms
... language-service, localize, platform-browser
... platform-browser-dynamic, router, service-worker
Ivy Workspace: Yes

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.900.4
@angular-devkit/build-angular      0.900.4
@angular-devkit/build-ng-packagr   0.900.4
@angular-devkit/build-optimizer    0.900.4
@angular-devkit/build-webpack      0.900.4
@angular-devkit/core               9.0.4
@angular-devkit/schematics         9.0.4
@angular/cdk                       9.1.0
@angular/cli                       9.0.4
@angular/material                  9.1.0
@ngtools/webpack                   9.0.4
@schematics/angular                9.0.4
@schematics/update                 0.900.4
ng-packagr                         9.0.0
rxjs                               6.5.4
typescript                         3.7.5
webpack                            4.41.2

[YarnSphere]

After upgrading to version 9.0.4 and deleting node_modules I got a lot of the following errors when running ng serve for the first time:

ERROR in Error when flattening the source-map "[path].d.ts.map" for "[path].d.ts": RangeError: Maximum call stack size exceeded

Interestingly, on the second run I got no more errors and, at a first glance, source maps seem to work (I'm not sure what this "flattening" process entails). ng build doesn't throw anymore either.

Angular CLI: 9.0.4
Node: 13.9.0
OS: linux x64

Angular: 9.0.4
... animations, cli, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router
Ivy Workspace: Yes

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.900.4
@angular-devkit/build-angular      0.900.4
@angular-devkit/build-ng-packagr   0.900.4
@angular-devkit/build-optimizer    0.900.4
@angular-devkit/build-webpack      0.900.4
@angular-devkit/core               9.0.4
@angular-devkit/schematics         9.0.4
@angular/cdk                       9.1.0
@ngtools/webpack                   9.0.4
@schematics/angular                9.0.4
@schematics/update                 0.900.4
ng-packagr                         9.0.2
rxjs                               6.5.4
typescript                         3.7.5
webpack                            4.41.2

[petebacondarwin]

@nunocastromartins - could you open an issue about the source-map flattening on the angular/angular repo and post some examples of the errors you saw?

[CastilloLuis]

It seems to be an Angular issue. I had a simliar issue after running npm run build, and I downgrade the following packages to their previous version:

@angular/cli from version 9.0.3 to 9.0.2
@anguar/compiler-cli from version 9.0.3 to 9.0.2

and everthing start working again.

[YarnSphere]

@petebacondarwin, I am now consistently getting the error during build and serve. I opened angular/angular#35757 to track it.