Arguments after files option should be considered files.

[michaeljota]

Bug Report or Feature Request (mark with an x)

- [ ] bug report -> please search issues before submitting
- [x] feature request

Command (mark with an x)

- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [x] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

Angular CLI: 7.1.0
Node: 8.12.0
OS: win32 x64
Angular:
...

Package                      Version
------------------------------------------------------
@angular-devkit/architect    0.11.0
@angular-devkit/core         7.1.0
@angular-devkit/schematics   7.1.0
@schematics/angular          7.1.0
@schematics/update           0.11.0
rxjs                         6.3.3

Repro steps

I'm using lint-staged to run several cli tools when commiting, including linting. As @angular/cli@6.1.9 I was able to use it as:

  "lint-staged": {
    "*.{ts,html}": [
      "ng lint my-app --fix",
      "git add"
    ],
  },

And in only ran on staged files. However, after upgrading to @angular/cli@7.1.0 it throws Unknown option:{// The route of the file that lint-staged passed as an argument}.

The log given by the failure

× ng lint my-app --fix --files found some errors. Please fix them and try committing again.
�[37mLinting "my-app"...�[39m

�[1m�[31mUnknown option: '~~~route\my.component.html'�[39m�[22m
�[1m�[31mUnknown option: '~~~route\my.component.ts'�[39m�[22m
�[1m�[31mUnknown option: '~~~route\.component.spec.ts'�[39m�[22m

Desired functionality

I think Angular CLI should be able to parse additional arguments in this scenario. ng lint --files should handle the arguments that comes from lint-staged.

Mention any other details that might be useful

I research, and find a "fix" in lint-staged#534. I upgrade the version of lint-staged and add the --files argument at the end of the command. Still, this doesn't work, I think because --files is expecting an array of files. lint-staged has an issue 138(open since March 2017, almost two years) requesting for a way to be able to tell how you want to pass the arguments.

[AndreiShostik]

I know that feel, bro. once again convinced that angular-cli sucks

tldr;
the only one workable solutions with ng lint is a enumeration of files with --files option: >ng lint --files src/app/app.module.ts --files src/app/shared/shared.module.ts and relative path only!
so better to use tslint directly.

---

https://angular.io/cli/lint#options - no info about how to use --files
https://github.com/angular/angular-cli/wiki/lint - the same no info

no matter how are you sending files via --files parameter it doesn't work properly at all. I even don't want to spend one more minute to poking around in angular-cli code to find how it exactly should be. it only accepts one file at a time. it uses blobs but as I understood you have exactly a enumeration of files.

0. >ng lint shows me errors which I need:

ERROR: src/app/app.module.ts:1:10 - " should be '
ERROR: src/app/shared/shared.module.ts:1:20 - " should be '

1. >ng lint --files src/app/app.module.ts src/app/shared/shared.module.ts - a space between files

An unhandled exception occurred: Project 'src/app/shared/shared.module.ts' does not support the 'lint' target.
See "angular-errors.log" for further details.

2. >ng lint --files src/app/app.module.ts,src/app/shared/shared.module.ts - comma between files

Linting "project"...
All files pass linting.

3. >ng lint --files=["src/app/app.module.ts","src/app/shared/shared.module.ts"] - an array

Linting "project"...
All files pass linting.

wtf?

4. >ng lint project --files "src/app/app.module.ts" "src/app/shared/shared.module.ts" - let's add a project maybe this will work

Unknown option: 'src/app/shared/shared.module.ts'

ugh, c`mon

5. >ng lint project --files "D:/project/src/app/app.module.ts" --files "D:/project/src/app/shared/shared.module.ts" - maybe project and absolute paths?

Option "files" was already specified with value ["D:/project/src/app/app.module.ts"]. The new value ["D:/project/src/app/app.module.ts","D:/project/src/app/shared/shared.module.ts"] will ove
rride it.
Linting "project"...
An unhandled exception occurred: File "D:\\project\\src\\app\\app.module.ts" is not part of a TypeScript project 'tsconfig.app.json,tsconfig.spec.json,e2e/tsconfig.json'.
See "angular-errors.log" for further details.

ah, f*** off angular-cli...

[headquarters]

As @AndreiShostik mentions above, one way is to pass multiple files to the command is via:

ng lint --files relative/path/file1.ts --files relative/path/file2.ts

However, there is another way to do this that is a bit more succinct. TSLint accepts glob patterns for file paths, so the following works as well:

ng lint --files '{relative/path/file1.ts,relative/path/file2.ts}'

Notice the argument passed to --files is a quoted string with curly braces inside {}. Inside the curly braces are comma-separated relative paths.

I think this is a poorly documented CLI command--the feature already exists, so this issue could probably be closed, but ideally the documentation would be updated to clarify what kind of argument is needed for multiple files with examples for globs.