fix for the digest bug #351
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid "Digest cycle already in progress" error.
to avoid "Digest cycle already in progress" error.
to avoid "Digest cycle already in progress" error.
|
Thanks for your pull request! This project hasn't been active in a while for a few reasons:
Seeing as I haven't spent much time on the project of late, it would help me greatly to understand whether it's worth the time to cut a release if you'd include some explanation of what this is trying to solve, and how the solution works. |
nbering
reviewed
Dec 29, 2020
| @@ -3,6 +3,7 @@ | |||
| angular.module('googlechart') | |||
| .directive('agcOnReady', onReadyDirective); | |||
|
|
|||
| onReadyDirective.$inject = ['$timeout']; | |||
| function onReadyDirective(){ | |||
There was a problem hiding this comment.
Looks like you're registering a dependency here, but didn't include a method argument to receive it. This should be throwing an error for $timeout is not a function when the callback actually runs.
Suggested change
| function onReadyDirective(){ | |
| function onReadyDirective($timeout){ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.