Change lookup value to dynamic value #93
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
anx-cbenke
suggested changes
Jul 29, 2020
There was a problem hiding this comment.
Universal approach to a user-defined lookup-field makes a lot of sense. I only ask you to explicate that it's not limited to email in the docs (Just insert a generic term instead of "custom_email_field", see the comment below)
Please also pull the recent changes from master and resolve the conflict in django_rest_passwordreset/views.py.
Comment on lines
144
to
148
| ## Custom Email Lookup | ||
|
|
||
| By default, `email` lookup is used to find the user instance. You can change that by adding | ||
| By default, `email` lookup is used to find the user instance. You can change that by adding | ||
| ```python | ||
| DJANGO_REST_LOOKUP_FIELD = 'custom_email_field' |
There was a problem hiding this comment.
The heading is no longer correct when the lookup-field can be anything, not only email.
'custom_email_field' should be changed to a more generic value too, to make clear that the lookup-field is not limited to an email-adress
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This package is limited to recovering passwords by email
Solution
Make the lookup field dynamic so it can be used for any field.
Example
You want to recover a user by
username,You set up the settings to
DJANGO_REST_LOOKUP_FIELD= 'username'.When calling the API, the request body should be
As a result, on the
ResetPasswordRequestTokenview the query will beusername__iexact="mycoolusername".