New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add "types" field to conditional exports #470
base: master
Are you sure you want to change the base?
Conversation
Related to #462 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's been more than a month now, someone had to do it to stop the PR from stagnating :)
Yea the types in this package doesn't work. In my vscode it says:
This with native ESM support. When I was using CJS, I could directly import the type files, hacking around the |
These are the types I care about:
They used to work when I was using CJS. Now I'm transitioning to ESM, and the last 2 imports no longer work. |
Co-authored-by: Altrue <9656008+Altrue@users.noreply.github.com>
@Altrue @tien Ah, thank you. I must admit I didn't test that as a required ordering to fields in JSON doesn't really make sense. I can't quite remember why I was running into this issue anymore ( |
@andywer are you still working on this? Without this PR I think ESM downstream projects can't use this. And I actually care about these types: #470 (comment) |
I'm experiencing a lot of issues when trying to resolve the types
The last error explicitly calls out that changes need to be made to the threads.js
package.json
. I've then added a "types" field for each of the conditional exports.