Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Blob worker docs #342

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pkerpedjiev
Copy link

Update the blob worker docs with an example webpack config file.

Shouldn't be necessary to do multiple webpack runs with this configuration.

@pkerpedjiev
Copy link
Author

@andywer What do you think of this PR? Anything I can do to make it more palatable?

@andywer
Copy link
Owner

andywer commented Feb 23, 2021

Great stuff! Thanks, @pkerpedjiev!

Unfortunately I didn't find the time to review any earlier. Could you also provide a test case (we have a few tests that build using webpack and then run the result)?

I haven't tested it yet. Are you actively using this approach?
Otherwise totally happy to merge it 🙂

@pkerpedjiev
Copy link
Author

Hey, sorry, I'm a little delayed in writing a test. While I dawdle on that, just wanted to say that I am actively using that approach and so far it's worked very well. Here's a link to the config file if you (or anybody else that comes across this) is interested:

https://github.com/higlass/higlass-pileup/blob/master/webpack.config.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants