Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added POST search & updated GET search for latest api version #601

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Fank
Copy link
Contributor

@Fank Fank commented Dec 16, 2022

What type of PR is this?

  • feature

What this PR does / why we need it:

Added POST search function in cloud.
General cleanup of the issue search in cloud.

Which issue(s) this PR fixes:

Fixes #395
Related #390

Special notes for your reviewer:

The search returns now the original json as struct instead of issue array and the issue array is untouched, marked as TODO for later fixes because it uses the wrong type as defined in documentation.
JQL is now inside the options block because both GET & POST are using this for building the URL as for JSON.

Additional documentation e.g., usage docs, etc.:

@Fank
Copy link
Contributor Author

Fank commented Dec 21, 2022

One of the main issues i was running into is that a major change between current v2 and new v3 in the API version is the issue field description which changed from a string into an unknown type.

v2:

"description": "dsffdsfd",

v3:

"description": {
  "version": 1,
  "type": "doc",
  "content": [
    {
      "type": "paragraph",
      "content": [
        {
          "type": "text",
          "text": "dsffdsfd"
        }
      ]
    }
  ]
},

Which causes a lot of issues with the struct IssueFields because it needs to be changed in all occurrences.

@andygrunwald
Copy link
Owner

Thanks @Fank!
I will check it out in the next days. Happy Xmas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Jira API v3
2 participants