Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added issue link #591

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added issue link #591

wants to merge 2 commits into from

Conversation

Fank
Copy link
Contributor

@Fank Fank commented Oct 27, 2022

What type of PR is this?

  • feature

What this PR does / why we need it:

It adds the missing issue link

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:

@andygrunwald
Copy link
Owner

Thanks for this Pull Request @Fank.
This is looking pretty good already!

A few things, that came into my mind:

Own Service

I am not 100% sure if we should run our own service here or consider making this part of the IssueService.
IssueLinks are pretty coupled to Issues.
And the IssueLinkService would be pretty small (only 3 methods).
I don't have a correct answer for me right now, just a thought.

Existing methods

In issue.go, we have already a few IssueLink API methods:

They are (still) a wild mix between On-Premise and Cloud, but I would consider removing those already.

Moving forward

Let me know your thoughts.
I can make the changes myself, while merging this into in the next couple of time/days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants