Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of all changes related to servicedesk #566

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Fank
Copy link
Contributor

@Fank Fank commented Sep 12, 2022

What type of PR is this?

  • feature
  • api-change

What this PR does / why we need it:

Its a backport from all related changes in servicedesk from https://github.com/mcl-de/go-jira/tree/fk_internal

Which issue(s) this PR fixes:

Related to #459, #458, #559, #560 & #561

Special notes for your reviewer:

Servicedesk API is a different API module compared to the Jira REST API, so i changed the naming of some of the files with a "servicedesk_" prefix and moved the models into a subfolder called servicedesk.
Not sure about the models subfolder yet, if the names are always different and if similar in name and properties this subfolder can be merged into the models folder.
But otherwise its way harder to split them again if we notice a difference.

Additional documentation e.g., usage docs, etc.:

@Fank
Copy link
Contributor Author

Fank commented Sep 13, 2022

I would check tests and other stuff which is missing when doing #559 (comment)

@github-actions github-actions bot added the conflicts Indicates merge conflicts label Oct 19, 2022
@andygrunwald
Copy link
Owner

Thanks for this Pull Request. It is still on my list to review. It might take a few days, thanks for understanding.

@andygrunwald andygrunwald mentioned this pull request Oct 30, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts Indicates merge conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants