Memoize function references with arguments #615
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
`ComposerLambdaMemoization` tried to prematurely prevent potential syntax addition not breaking function reference optimization by checking for amount of value parameters. This inadvertently broke memoization of function references to methods with more than zero arguments, since `IrFunctionReferenceImpl` currently reflects the amount of value arguments in the referenced function. Add a check to disable memoization for function references with context receivers. Kotlin doesn't support them yet, and behavior might change in the future. Test: Added new tests to `LambdaMemoizationTransformTests`: * `testNonComposableFunctionReferenceWithNoArgumentsMemoization` * `testNonComposableFunctionReferenceWithArgumentsMemoization` * `testNonComposableFunctionReferenceWithStableContextReceiverNotMemoized` Fixes: b/302680514 Relnote: Memoize function references with arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
ComposerLambdaMemoizationtried to prematurely prevent potential syntax addition not breaking function reference optimization by checking for amount of value parameters.This inadvertently broke memoization of function references to methods with more than zero arguments, since
IrFunctionReferenceImplcurrently reflects the amount of value arguments in the referenced function.Add a check to disable memoization for function references with context receivers. Kotlin doesn't support them yet, and behavior might change in the future.
Testing
Test: Added new tests to
LambdaMemoizationTransformTests:testNonComposableFunctionReferenceWithNoArgumentsMemoizationtestNonComposableFunctionReferenceWithArgumentsMemoizationtestNonComposableFunctionReferenceWithStableContextReceiverNotMemoizedIssues Fixed
Fixes: b/302680514