Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat kotlinx.collections.immutable.ImmutableCollection as stable #462

Open
wants to merge 1 commit into
base: androidx-main
Choose a base branch
from

Conversation

mcpiroman
Copy link

This will make parameters that have more general type of ImmutableCollection rather than List or Set stable.

@google-cla
Copy link

google-cla bot commented Nov 9, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jimgoog
Copy link
Collaborator

jimgoog commented Nov 11, 2022

👍 Seems reasonable to me. CLA required, see instructions from CLA bot. Also, lint is complaining that there is no unit test stanza, you can amend your commit message to say Test: unit tests that will make lint happy.

This will make parameters that have more general type of `ImmutableCollection` rather than List or Set stable.

Test: unit tests
@mcpiroman
Copy link
Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants