Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update List-Detail sample to Material 3 Adaptive #460

Merged
merged 2 commits into from Apr 19, 2024
Merged

Update List-Detail sample to Material 3 Adaptive #460

merged 2 commits into from Apr 19, 2024

Conversation

tiwiz
Copy link
Contributor

@tiwiz tiwiz commented Mar 26, 2024

Update List-Detail sample to Material 3 Adaptive

@tiwiz tiwiz added the enhancement New feature or request label Mar 26, 2024
IanGClifton
IanGClifton reviewed Mar 28, 2024
View reviewed changes
Copy link

@IanGClifton IanGClifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but probably Alex should also look. One alternative is that the selected word index could be used as the ID directly with the navigator instead of using , but I don't have a strong opinion on whether that's better or just different.

alexvanyo
alexvanyo reviewed Apr 11, 2024
View reviewed changes
Copy link
Contributor

@alexvanyo alexvanyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than the one comment to preserve the selection visibility behavior using scaffoldValue.

+1 that we could use the navigator's type to store the id, that'd be a neat follow-up PR to see the diff for just making that refactor.

...s/list-detail-compose/app/src/main/java/com/example/listdetailcompose/ui/ListDetailSample.kt Show resolved Hide resolved
alexvanyo
alexvanyo approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@alexvanyo alexvanyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tiwiz tiwiz merged commit a14e648 into android:main Apr 19, 2024
2 checks passed
@tiwiz tiwiz deleted the ro_list_detail_alpha09 branch April 19, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanGClifton IanGClifton IanGClifton left review comments

@alexvanyo alexvanyo alexvanyo approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tiwiz @IanGClifton @alexvanyo