Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translated the remaining strings #924

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pandu-12345
Copy link

No description provided.

@pandu-12345 pandu-12345 requested a review from a team as a code owner October 20, 2023 21:33
@google-cla
Copy link

google-cla bot commented Oct 20, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

@mlykotom mlykotom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

<string name="gallery_title">(translate me) Photos by Unsplash</string>
<string name="gallery_content_description">(translate me) Navigate to gallery screen</string>
<string name="gallery_title">Photos par Unsplash</string>
<string name="gallery_content_description">Naviguer vers l'écran de la galerie</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<string name="gallery_content_description">Naviguer vers l'écran de la galerie</string>
<string name="gallery_content_description">Naviguer vers l\'écran de la galerie</string>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is causing the build issue. You need to fix it first before applying. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants