Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the visibility of the 'Add' button when the content is scrolled #894

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix the visibility of the 'Add' button when the content is scrolled #894

wants to merge 4 commits into from

Conversation

yosefmoq
Copy link
Contributor

@yosefmoq yosefmoq commented Jul 1, 2023 •
edited

This pull request fixes issue #889
This PR is part of GTC open source initiative

@yosefmoq yosefmoq requested a review from a team as a code owner July 1, 2023 18:55
@yosefmoq yosefmoq requested a review from mlykotom July 1, 2023 18:55
@yosefmoq yosefmoq changed the base branch from main to views July 2, 2023 07:23
@yosefmoq yosefmoq changed the base branch from views to main July 2, 2023 07:24
arriolac
arriolac requested changes Jul 12, 2023
View reviewed changes
Copy link
Member

@arriolac arriolac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the correct fix. Best to toggle visibility based on scroll position. Bonus point is to use AnimatedVisibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arriolac arriolac arriolac requested changes

@mlykotom mlykotom Awaiting requested review from mlykotom mlykotom is a code owner automatically assigned from android/compose-devrel

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yosefmoq @arriolac