Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Persian (fa) Locale #751

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Added Persian (fa) Locale #751

wants to merge 4 commits into from

Conversation

ehsanr-r
Copy link

I added a new strings.xml file to support the Persian language.

@Arrowsome
Copy link

There are multiple other pull request like this, you could've checked theme before making a pull request. #739 #642.

@LinX64 LinX64 mentioned this pull request Aug 25, 2022
Closed
@arriolac
Copy link
Member

arriolac commented Dec 20, 2023 •
edited

Thanks for the contribution! There are a couple more strings missing:

  • a11y_plant_item_image
  • a11y_back
    Once updated, we can go ahead and merge this in.

@ehsanr-r ehsanr-r requested a review from a team as a code owner December 22, 2023 19:19
@arriolac arriolac requested review from arriolac and removed request for riggaroo December 26, 2023 17:35
arriolac
arriolac approved these changes Dec 26, 2023
View reviewed changes
Copy link
Member

@arriolac arriolac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please sign CLA and will merge in. Thanks!

@arriolac
Copy link
Member

CLA still failing (see https://github.com/android/sunflower/pull/751/checks?check_run_id=19988830749). Alternatively, you can open a new PR with a commit signed by an email address you used to sign the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arriolac arriolac arriolac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ehsanr-r @Arrowsome @arriolac