Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve BookmarksViewModelTest coverage #1399

Conversation

hiroaki404
Copy link

@hiroaki404 hiroaki404 commented Apr 24, 2024

What I have done and why

  • Improve coverage of BookmarksViewModel
  • Add test for setNewsResourceViewed method and undoBookmarkRemoval method

Fixes #1333

How I'm testing it

  • Unit tests

Do tests pass?

  • Run local tests on DemoDebug variant: ./gradlew testDemoDebug
  • Check formatting: ./gradlew --init-script gradle/init.gradle.kts spotlessApply

Is this your first pull request?

Change-Id: I701914ab4b939a2f8ec47367aab28075b1e67e1f
Copy link

google-cla bot commented Apr 24, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@hiroaki404 hiroaki404 closed this Apr 24, 2024
@hiroaki404 hiroaki404 deleted the test/improve_bookmark_viewmodel_coverage branch April 24, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Testing FR] [feature:bookmarks] Improve coverage of viewmodel
1 participant