add internal keyword to SettingsDialog #1389
Open
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a pull request. Please include the following information.
What I have done and why
The Internal keyword was added to settingDialog, which is only referenced inside the module.
It seems there is no need to use it externally.
How I'm testing it
I simply built and ran it.
Do tests pass?
DemoDebug
variant:./gradlew testDemoDebug
./gradlew --init-script gradle/init.gradle.kts spotlessApply
Is this your first pull request?
./tools/setup.sh