New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding shared elements to Jetsnack 🎉 #1314
Open
riggaroo
wants to merge
45
commits into
compose-latest
Choose a base branch
from
jetsnack/shared-element
base: compose-latest
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 42 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
5577a50
Adding Shared elements to Jetsnack
riggaroo b4b8bd0
Adding Shared elements to Jetsnack
riggaroo 32bf222
Adding Shared elements to Jetsnack
riggaroo 3393f6b
Throw IllegalStateException instead of IllegalArgumentException.
riggaroo d54a398
Place background on whole screen.
riggaroo 03d9235
Cleanup
riggaroo e8bc672
disable predictive back for now.
riggaroo 9db6c53
Added a debugPlaceholder for Previews.
riggaroo bcd5d1c
Set ExitTransition.None and using sharedBounds instead of sharedElement.
riggaroo 61a9c94
Set ExitTransition.None and using sharedBounds instead of sharedElement.
riggaroo 7852d36
Only display IconButton when the transition isn't active anymore.
riggaroo e326aaf
skipToLookaheadSize() for Text description to prevent reflowing of co…
riggaroo b532356
Added background back to the headings
riggaroo 27a9d9d
Ordering cleanup
riggaroo e23e553
Change CompositionLocals to be individually provided
riggaroo 3592280
Shared element tweaking
riggaroo 844a8d6
change spring spec to expressive
riggaroo cc61fa7
Changed to expressive baseline
riggaroo 70bd4c4
Fix previews.
riggaroo 92fc2ba
Polish animation
riggaroo 7c2574b
Polish animation
riggaroo bc49bbe
Slide TopAppBar up when shared element animates
riggaroo e4abbae
Update springs to use expressive
riggaroo 515d402
Animate clipping as it goes.
riggaroo 09f9a0b
Code clean up
riggaroo ed03bbd
Code clean up
riggaroo b218908
Code clean up
riggaroo 9e481e8
Merge branch 'refs/heads/bugfix/fix-debug-keystores' into jetsnack/sh…
riggaroo 61b7a5e
Switch to alpha version of compose
riggaroo c44327e
Formatting
riggaroo bd0b871
Formatting
riggaroo 61883bc
Merge branch 'main' into jetsnack/shared-element
riggaroo 10e0ad5
Update to new recommendations for async images.
riggaroo fa6a864
🤖 Apply Spotless
riggaroo 0f4b958
Update Back icon animation.
riggaroo 392262c
Tidied up the enter animations of non-shared items.
riggaroo 45df731
Merge branch 'jetsnack/shared-element' of https://github.com/android/…
riggaroo a40c152
Spotless
riggaroo 11313dd
🤖 Apply Spotless
riggaroo aa6246d
Add item animations to cart screen
riggaroo 5250858
Merge branch 'jetsnack/shared-element' of https://github.com/android/…
riggaroo e7cecfc
🤖 Apply Spotless
riggaroo a58f230
Update to 1.7.0-beta01, and switch to ResizeMode.
riggaroo bc662ec
Merge branch 'jetsnack/shared-element' of https://github.com/android/…
riggaroo bbfa61e
🤖 Apply Spotless
riggaroo File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cupcake above still has a fixed ID. Do these IDs need to be random? Also, isn't it now possible (albeit very improbable) that two snacks end up with the same ID?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its for preview purposes to be able to query for a certain snack. yes it is somewhat possible, but this is fake mock data so I dont think its worth the hassle of making it more robust.