-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved the ViewModelProvider Factory to require less boilerplate #921
base: main
Are you sure you want to change the base?
Improved the ViewModelProvider Factory to require less boilerplate #921
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@googlebot I fixed it. |
@dlam @ianhanniballake Would you mind reviewing this, please? |
GithubBrowserSample/app/src/main/java/com/android/example/github/ui/repo/RepoFragment.kt
Show resolved
Hide resolved
@yigit I'd really appreciate if you would find the time to have a look at this. |
The approach I am suggesting removes the need for ViewModelModule, decreasing the boilerplate
Note: This new approach has the exact same level of compile-time safety as the one being replaced.