Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the ViewModelProvider Factory to require less boilerplate #921

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AlexDochioiu
Copy link

@AlexDochioiu AlexDochioiu commented Oct 26, 2020

The approach I am suggesting removes the need for ViewModelModule, decreasing the boilerplate

Note: This new approach has the exact same level of compile-time safety as the one being replaced.

@google-cla
Copy link

google-cla bot commented Oct 26, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@AlexDochioiu
Copy link
Author

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Oct 26, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@AlexDochioiu
Copy link
Author

@googlebot I fixed it.

@AlexDochioiu
Copy link
Author

@dlam @ianhanniballake Would you mind reviewing this, please?

@AlexDochioiu
Copy link
Author

@yigit I'd really appreciate if you would find the time to have a look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants