Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

afterObserve.invoke() only if latch is satisfied #1068

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

afterObserve.invoke() only if latch is satisfied #1068

wants to merge 1 commit into from

Conversation

dgochev
Copy link

@dgochev dgochev commented Dec 8, 2022

getOrAwaitValue in LiveDataTestUtil should invoke afterObserve only if the latch is satisfied (i.e. data was changed)

@dgochev
afterObserve.invoke() only if latch is satisfied
52705b8 
`getOrAwaitValue` in `LiveDataTestUtil` should invoke `afterObserve` only if the latch is satisfied (i.e. data was changed)
@dgochev
Copy link
Author

dgochev commented Dec 8, 2022

Seems like the latch isn't entirely serving its purpose, and afterObserve isn't actually being done after observing. Maybe the name just isn't clear -- is the purpose of afterObserve to do something right after the .observeForever?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dgochev