Removed the deprecated jcenter(), updated AGP to 4.2.2 for build scripts #1016
Conversation
| @@ -50,7 +50,7 @@ versions.mockito = "2.25.0" | |||
| versions.mockito_all = "1.10.19" | |||
| versions.mockito_android = "2.25.0" | |||
| versions.mockwebserver = "3.8.1" | |||
| versions.navigation = "2.4.0-alpha01" | |||
| versions.navigation = "2.3.0-alpha01" | |||
There was a problem hiding this comment.
any reason we had to downgrade this?
There was a problem hiding this comment.
not really: the top level tool does that, it copies versions from root versions.gradle to almost all sub-directories, except GithubBrowserSample and MADSkillNavigationSample, it is kind of neat. Do you want to retain this version for this sample, or it could align with the rest, and update together with the rest at one shot later?
There was a problem hiding this comment.
ah i see, that's a neat tool. updating it later together with the rest sounds good.
There was a problem hiding this comment.
sorry to go back on what i said, but i think we should keep the 2.4.0 version because of @yenerm's recent PR that specifically updated the sample to use the newer version: https://github.com/android/architecture-components-samples/pull/993/files
There was a problem hiding this comment.
done: uploaded with the latest version for these 3 alpha releases, applied to all and compileSdkVersion has to be 31(the latest), it is a little bold, but should work (test build a few), PTAL.
| @@ -1,6 +1,22 @@ | |||
| #Wed May 12 09:57:18 PDT 2021 | |||
| # | |||
There was a problem hiding this comment.
Looks like the CI is failing on 4 samples, those should be fixed before committing
From one of them (test_rx_java_sample_kotlin —):
FAILURE: Build failed with an exception.
- What went wrong:
Could not determine the dependencies of task ':app:lint'.
Could not resolve all artifacts for configuration ':app:debugAndroidTestCompileClasspath'.
Could not find com.linkedin.dexmaker:dexmaker-mockito:2.2.0.
Required by:
project :app
No description provided.