Ensure all Fields and Strings get wrapped as FieldAnalysis and StringAnalysis respectivly when creating Analysis #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… If we make a new Analysis field attribute, none of the downstream XREF analysis will get propagated to it
…ions for getting FieldIdItems and MethodIdItems vs. EncodedFields and EncodedMethods, normalize variable names to be consistent where designs overlap, and create additional 'get_len_xxx()' functions for classes
…. fix failing test mentioned in androguard#989 so that it assumes testing for wrapped fields. make new tests for DEX-class level testing that tests counts of parsed values in the DEX header
…g when creating new ClassAnalysis instance. Similar to wrapping all fields into FieldAnalysis, also add and wrap all strings into StringAnalysis. Create explicit methods for getting internal/external methods. Updated expected outputs for test_analysis, as underlying implementations have changed
… refactor-analysis
|
@ehrenb great work done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to: #989 (comment)
FieldAnalysisStringAnalysistest_analysis.pyunittest, because number of fields and strings returned are now increased