Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On custom resource creation, return domain name as physical resource ID #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

On custom resource creation, return domain name as physical resource ID #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 8 additions & 2 deletions index.js
View file
Open in desktop
Expand Up @@ -44,7 +44,7 @@ var Update = CfnLambda.SDKAlias({
});

function getPhysicalId(data, params) {
return CfnLambda.Environment.AccountId + '/' + params.DomainName;
return params.DomainName;
}

exports.handler = CfnLambda({
Expand Down Expand Up @@ -79,7 +79,13 @@ function CheckProcessComplete(params, reply, notDone) {
return notDone();
}
console.log('Status is Processing: false! %j', domain);
reply(null, domain.DomainStatus.DomainId, {
// NOTE: we are using the response from describeElasticsearchDomain here instead of
// the DomainName passed through CR params, as getPhysicalId does
// this is what is responsible for returning the CR's physical ID on creation,
// used by references in CFN.
// TODO: to make the returnPhysicalId key usage in SDKAlias be intuitive,
// test this with Params.DomainName and change if it works
reply(null, domain.DomainStatus.DomainName, {
Endpoint: domain.DomainStatus.Endpoint
});
});
Expand Down