Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve last requests mistakes #17593

Open
wants to merge 48 commits into
base: master
Choose a base branch
from
Open

resolve last requests mistakes #17593

wants to merge 48 commits into from

Conversation

hougomartim
Copy link
Contributor

No description provided.

@hougomartim
Copy link
Contributor Author

resolve the last pull request mistakes, sorry for lating, Thanks to you ./

@andresriancho
Copy link
Owner

Still multiple bugs

andresriancho
andresriancho reviewed Feb 4, 2019
View reviewed changes
Copy link
Owner

@andresriancho andresriancho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the bugs I've found

w3af/core/controllers/core_helpers/exception_handler.py Outdated Show resolved Hide resolved
w3af/core/ui/api/tests/test_exceptions.py Outdated Show resolved Hide resolved
w3af/plugins/attack/db/sqlmap/lib/core/wordlist.py Outdated Show resolved Hide resolved
w3af/plugins/audit/redos.py Show resolved Hide resolved
w3af/plugins/tests/crawl/phpinfo/phpinfo-5.1.3-rc4dev.html Outdated Show resolved Hide resolved
w3af/plugins/tests/crawl/phpinfo/phpinfo-5.1.6.html Outdated Show resolved Hide resolved
@hougomartim
Copy link
Contributor Author

thanks for reviews.

@hougomartim
Copy link
Contributor Author

@andresriancho
Request a review. Thank you so much.

@andresriancho
Copy link
Owner

This change looks much better than before.

Something I noticed was that the change also impacts the sqlmap source code we embed in w3af/plugins/attack/db/sqlmap. The next time I merge the latest sqlmap into that directory in w3af, those changes will be overwritten / generate lots of merge conflicts. Please ignore that directory for now.

Something else I noticed is that I dislike large pull requests like this one, they are hard to review and I always think that someone will try to PR a backdoor. Since this change is generated in an automated way, would it be possible for you to send me the command you're using to change the files and I just apply that command?

hougomartim
hougomartim commented Oct 30, 2019
View reviewed changes
Copy link
Contributor Author

@hougomartim hougomartim left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for reviewing the more than 150 files.
i ignore the sqlmap directory and i search in history commands prompt, but i can`t find thats command.

@hougomartim
Copy link
Contributor Author

hougomartim commented Oct 30, 2019 •
edited

i will sending a small pull request in the next.
Thanks again./

@hougomartim
Copy link
Contributor Author

can you merge this request?

@hougomartim
Copy link
Contributor Author

this is ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresriancho andresriancho Awaiting requested review from andresriancho

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hougomartim @andresriancho