Critical Fix. Buffer overflow caused random device reboot or hang. Malloc result checking in addReg and exceptionalResponce. Wrong value for every 8-th reg in read/writeCoils, readInputStats. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
addReg and exceptionalResponce needs to be extended with malloc() result checking. |
emelianov
changed the title
emelianov
changed the title
emelianov
changed the title
|
Fix wrong value for every 8-th reg in read/writeCoils, readInputStats |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With some devices Modbus IP packet size is grater than specified in header. So count of bytes to read should be limited by buffer size not packet size from header.