Replace fzaninotto/faker with fakerphp/faker #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, I see Travis was not connected to automatically run on PRs. Then I'd like to give more information how I've tested this change using my own project https://github.com/bjuppa/laravel-blog In the So, the changes in this PR at least works with this Travis setup in my package, covering PHP |
|
@andrefigueira are this changes acceptable to be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is replacing the dependency on deprecated
fzaninotto/fakerwith the community maintainedfakerphp/fakerpackage.See #2 for more details!
I haven't gotten the tests to run locally because of PHP versions, so I'm creating this PR in an attempt to trigger Travis builds.
I'm expecting to edit the Travis config along the way if tests doesn't pass.