Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: options not being correctly read when loaded before cmp #30

Merged
merged 1 commit into from Feb 29, 2024

Conversation

lljbash
Copy link
Contributor

@lljbash lljbash commented Jan 15, 2024

by delaying the initialization of source.

fixes #29

The API remains unchanged.

by delaying the initialization of `source`.

fixes andersevenrud#29
@andersevenrud
Copy link
Owner

Nice! I haven't had a chance to check this out yet, but looks promising!

I'll get back to you this weekend

@lljbash lljbash changed the title fix options not being correctly read when loaded before cmp fix: options not being correctly read when loaded before cmp Jan 25, 2024
@lljbash
Copy link
Contributor Author

lljbash commented Feb 26, 2024

Nice! I haven't had a chance to check this out yet, but looks promising!

I'll get back to you this weekend

friendly ping 👀

Copy link
Owner

@andersevenrud andersevenrud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply. I've been quite busy recently, but finally had some time to check this out.

Seems to be working fine 👍

@andersevenrud andersevenrud merged commit 95b1b92 into andersevenrud:main Feb 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

This plugin must be loaded after cmp to make options work
2 participants