This repository has been archived by the owner on Jun 14, 2022. It is now read-only.
Fixed: Crash when filling password using Magikeyboard from KeePassDX (#866) #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When entering the password using the Magikeyboard from KeePassDX, the `event` was `null`, which resulted in the app crashing.
|
Hey @flocke, have you had the time to take a look at this? Is there anything I can do to further this pull request? I'm happy to assist with testing and documentation, even though I'm still new to Android development. Thanks in advance for your time, I highly appreciate it! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this branch, the app no longer crashes when filling the password using the Magikeyboard from KeePassDX.
This pull request resolves #866, and steps to reproduce/test the behaviour can be found in the bug report.