Fsylvestre/ad7944 #562
Open
Fsylvestre/ad7944 #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add adi/ad7944.py module - Add ad7944 to index.rst - Add ad7944 to supported_parts.md - Add ad7944 doc stub - Add test/ad7944.py test, xml file - Add ad7944 to hardware_map.xml Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com> Signed-off-by: Florian Sylvestre <fsylvestre@baylibre.com>
Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com> Signed-off-by: Florian Sylvestre <fsylvestre@baylibre.com>
Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Signed-off-by: Florian Sylvestre <fsylvestre@baylibre.com>
fsylvestre
force-pushed
the
fsylvestre/ad7944
branch
from
a49a8f0
to
f6f8009
Compare
tfcollins
reviewed
May 16, 2024
| _device_name = "" | ||
| _rx_data_type = np.uint16 | ||
|
|
||
| _rx_channel_names = [] |
There was a problem hiding this comment.
This need to be reset to [] in the init or just defined by the init. Class properties act like static properties, so using multiple instances will cause undesired behavior
tfcollins
reviewed
May 16, 2024
|
|
||
| if not self._ctrl: | ||
| raise Exception(f"Error in selecting matching device {device_name}") | ||
|
|
There was a problem hiding this comment.
Please add a check for self._ctrl as well
There was a problem hiding this comment.
Sorry, meant self._rxadc
There was a problem hiding this comment.
In this case I don't get it as self._rxadc = self._ctrl, so if self._ctrl is not None it's the same for self._rxadc. No?
tfcollins
requested changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Please delete options that are not relevant.
How has this been tested?
Tested against AD7944, AD7986 and AD7985 eval boards attached to a zedboard.
Generalized manual test flow:
install pyadi-iio and dependencies in venv
Start Python interpreter
import adi
Instantiate adc object, e.g. adc = adi.ad7944(uri="ip:10.2.5.203")
Check that adc.rx() succeeds with no warnings or errors
Check sampling frequency with adc.sampling_frequency
Set sampling frequency with adc.sampling_frequency =
Check sampling frequency again with adc.sampling_frequency and confirm change successful
pytest --hw=ad7944 -v test/test_ad7944.py --uri=ip:10.2.5.203and
pytest -v --emu --emu-xml=ad7944.xml test/test_ad7944.pyTest Configuration:
Hardware: Zedboard + EVAL-AD7944FMCZ/EVAL_AD7944_85_86FMCZ
OS:
PRETTY_NAME="Kuiper GNU/Linux 11.2 (bullseye)"
NAME="Kuiper GNU/Linux"
VERSION_ID="11.2"
VERSION="11.2 (bullseye)"
VERSION_CODENAME=bullseye
ID=raspbian
ID_LIKE=debian
HOME_URL="https://github.com/analogdevicesinc/adi-kuiper-gen"
SUPPORT_URL="https://ez.analog.com/linux-software-drivers/"
Documentation
Added:
Updated:
Checklist: