New adis support #2411
New adis support #2411
Conversation
rbolboac
commented
Jan 25, 2024
rbolboac
commented
- add support for ADIS16501 in adis16475 driver
- add support for ADIS1657X family in adis16475 driver
- add FIFO support for ADIS1657X family
rbolboac
force-pushed
the
dev/adis1657x
branch
from
c11f232
to
eee4ba8
Compare
rbolboac
force-pushed
the
dev/adis1657x
branch
2 times, most recently
from
a19a6ba
to
ab05734
Compare
rbolboac
force-pushed
the
dev/adis1657x
branch
3 times, most recently
from
2ff961f
to
6bb0677
Compare
|
rbolboac
requested review from
mhennerich,
dbogdan,
btogorean,
chegbeli,
buha,
amiclaus,
danmois,
CiprianRegus and
machschmitt
as code owners
drivers/iio/imu/adis16475.c
Outdated
| struct adis *adis = &st->adis; | ||
|
|
||
| adis->burst_req_msb = burst_req; | ||
| adis_update_scan_mode(indio_dev, indio_dev->active_scan_mask); |
There was a problem hiding this comment.
Hmm, If I'm not missing nothing the only thing we wanna change is the burst_req command right? So, doing kfree() plus kzalloc() on every sample is definitely too much... I would just change the byte in adis->xfer[0] and then restore it after burst_req is done. Note that we're already directly messing with the transfer size in adis16475_burst32_check() anyways. I admit is not that pretty but better than the allocation overhead. At some point (if we get another driver needing stuff like this) we may think in moving this to a better API in the lib. But for now, I would just do it in here...
With the above, I guess you can drop the patch for adis->burst_req_msb
There was a problem hiding this comment.
so changing the byte in adis->xfer[0] is a little tricky because tx_buff is const void *, so I had to use the same lines of code as in adis_update_scan_mode_burst, I hope this is alright. do you have another suggestion?
drivers/iio/imu/adis16475.c
Outdated
| struct iio_dev *indio_dev = pf->indio_dev; | ||
| struct adis16475 *st = iio_priv(indio_dev); | ||
| struct adis *adis = &st->adis; | ||
| u8 *tx = adis->buffer + adis->data->burst_max_len; |
There was a problem hiding this comment.
Yeps, exactly what I had in mind. But, are we guaranteed to always have adis->data->burst_max_len? We handle it a bit different in update_scan_mode_burst().
Also, see below...
drivers/iio/imu/adis16475.c
Outdated
|
|
||
| tx[0] = ADIS_READ_REG(burst_req); | ||
| tx[1] = 0; | ||
| adis->xfer[0].tx_buf = tx; |
There was a problem hiding this comment.
I do not think we need the above two lines. Just tx[0] = ADIS_READ_REG(burst_req); should be enough. The pointer is the same. We're just changing the first byte under the wood :)
I admit this is not pretty as it should be the lib to handle this internal data. When upstreaming, feel free to purpose something like adis_update_burst_request()... The only thing I don't like with having it in the lib is that we just have one user for it. Up to you anyways.
Sure, currently I am waiting for some feedback from the MEMS team to make sure nothing has changed in the meanwhile. |
Update ADIS16475 existing documentation with documentation for ADIS16501 device. Signed-off-by: Ramona Gradinariu <ramona.gradinariu@analog.com>
Add support for ADIS16501 device in already existing ADIS16475 driver. Datasheet: TBD Signed-off-by: Ramona Gradinariu <ramona.gradinariu@analog.com>
Re-define ADIS16475_DATA such that it takes _burst_max_len and _burst_max_speed_hz as parameters. Signed-off-by: Ramona Gradinariu <ramona.gradinariu@analog.com>
Add new API called devm_adis_setup_buffer_and_trigger_with_attrs() which also takes buffer attributes as a parameter. Rewrite devm_adis_setup_buffer_and_trigger() implementation such that it calls devm_adis_setup_buffer_and_trigger_with_attrs() with buffer attributes parameter NULL. Signed-off-by: Ramona Gradinariu <ramona.gradinariu@analog.com>
Create push single sample API reposnsible for pushing a single sample into the buffer. This is a preparation patch for FIFO support where more than one sample has to be pushed in the trigger handler. Signed-off-by: Ramona Gradinariu <ramona.gradinariu@analog.com>
Update ADIS16475 existing documentation with documentation for ADIS1657X family devices. Signed-off-by: Ramona Gradinariu <ramona.gradinariu@analog.com>
Add support for ADIS1657X family devices in already exiting ADIS16475 driver. Datasheet: TBD Signed-off-by: Ramona Gradinariu <ramona.gradinariu@analog.com>
|
