-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add max14001 support #2141
base: main
Are you sure you want to change the base?
add max14001 support #2141
Conversation
f6187f8
to
11e7191
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's still some work to be done on this one...
Also note that I expect you to first send this driver upstream before merging it with our master tree.
f58cd45
to
ef0ab84
Compare
Changelogs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also make sure to fix your bindings. CI is failing to pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more comments on my side. I think you can already take those comments and prepare a patchset to send upstream.
Add bindings for MAX14001. The MAX14001 is configurable, isolated 10-bit ADCs for multi-range binary inputs. Signed-off-by: Kim Seer Paller <kimseer.paller@analog.com>
Add driver implementation for max14001. The MAX14001 is configurable, isolated 10-bit ADCs for multi-range binary inputs. Signed-off-by: Kim Seer Paller <kimseer.paller@analog.com>
Add entry for the MAX14001 driver. Signed-off-by: Kim Seer Paller <kimseer.paller@analog.com>
@kseerp, what's the state of this PR? Do you have plans to upstream this? |
this has already been sent upstream. should this PR be closed for now? |
Was it accepted already? If so, please sync this PULL so we can merge the driver |
It's not yet accepted. I will follow up on it, once accepted, I'll update this PR and let you know. Thanks. |
The MAX14001 is configurable, isolated 10-bit ADCs for multi-range binary inputs.
Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/max14001-max14002.pdf
Signed-off-by: Kim Seer Paller kimseer.paller@analog.com