Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add max14001 support #2141

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

kseerp
Copy link
Contributor

@kseerp kseerp commented Mar 16, 2023

The MAX14001 is configurable, isolated 10-bit ADCs for multi-range binary inputs.

Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/max14001-max14002.pdf

Signed-off-by: Kim Seer Paller kimseer.paller@analog.com

@kseerp kseerp force-pushed the dev/max14001 branch 2 times, most recently from f6187f8 to 11e7191 Compare March 16, 2023 06:30
@nunojsa nunojsa requested a review from a team March 21, 2023 10:07
Copy link
Collaborator

@nunojsa nunojsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still some work to be done on this one...

Also note that I expect you to first send this driver upstream before merging it with our master tree.

drivers/iio/adc/max14001.c Outdated Show resolved Hide resolved
drivers/iio/adc/max14001.c Show resolved Hide resolved
drivers/iio/adc/max14001.c Show resolved Hide resolved
drivers/iio/adc/max14001.c Outdated Show resolved Hide resolved
drivers/iio/adc/max14001.c Outdated Show resolved Hide resolved
drivers/iio/adc/max14001.c Outdated Show resolved Hide resolved
drivers/iio/adc/max14001.c Show resolved Hide resolved
drivers/iio/adc/max14001.c Outdated Show resolved Hide resolved
@kseerp kseerp marked this pull request as draft March 24, 2023 02:58
@kseerp kseerp force-pushed the dev/max14001 branch 2 times, most recently from f58cd45 to ef0ab84 Compare March 28, 2023 03:56
@kseerp
Copy link
Contributor Author

kseerp commented Mar 28, 2023

Changelogs:

  • changed types and added __aligned(IIO_DMA_MINALIGN) on buffers
  • added software power on reset
  • added error handling for every calls
  • improved code comments
  • moved functions close to the call site
  • modified and used optional regulator
  • included additional device configurations instead of relying on default settings

@kseerp kseerp marked this pull request as ready for review March 28, 2023 05:13
Copy link
Collaborator

@nunojsa nunojsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also make sure to fix your bindings. CI is failing to pass

drivers/iio/adc/max14001.c Outdated Show resolved Hide resolved
drivers/iio/adc/max14001.c Outdated Show resolved Hide resolved
drivers/iio/adc/max14001.c Show resolved Hide resolved
drivers/iio/adc/max14001.c Show resolved Hide resolved
drivers/iio/adc/max14001.c Outdated Show resolved Hide resolved
drivers/iio/adc/max14001.c Outdated Show resolved Hide resolved
drivers/iio/adc/max14001.c Show resolved Hide resolved
Copy link
Collaborator

@nunojsa nunojsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments on my side. I think you can already take those comments and prepare a patchset to send upstream.

drivers/iio/adc/max14001.c Outdated Show resolved Hide resolved
drivers/iio/adc/max14001.c Outdated Show resolved Hide resolved
drivers/iio/adc/max14001.c Outdated Show resolved Hide resolved
drivers/iio/adc/max14001.c Outdated Show resolved Hide resolved
drivers/iio/adc/max14001.c Outdated Show resolved Hide resolved
drivers/iio/adc/max14001.c Outdated Show resolved Hide resolved
drivers/iio/adc/max14001.c Show resolved Hide resolved
drivers/iio/adc/max14001.c Show resolved Hide resolved
Add bindings for MAX14001.

The MAX14001 is configurable, isolated 10-bit ADCs for multi-range
binary inputs.

Signed-off-by: Kim Seer Paller <kimseer.paller@analog.com>
Add driver implementation for max14001.

The MAX14001 is configurable, isolated 10-bit ADCs for multi-range
binary inputs.

Signed-off-by: Kim Seer Paller <kimseer.paller@analog.com>
Add entry for the MAX14001 driver.

Signed-off-by: Kim Seer Paller <kimseer.paller@analog.com>
@SRaus SRaus changed the base branch from master to main January 9, 2024 09:49
@nunojsa
Copy link
Collaborator

nunojsa commented Jan 15, 2024

@kseerp, what's the state of this PR? Do you have plans to upstream this?

@kseerp
Copy link
Contributor Author

kseerp commented Jan 17, 2024

@kseerp, what's the state of this PR? Do you have plans to upstream this?

this has already been sent upstream. should this PR be closed for now?

@nunojsa
Copy link
Collaborator

nunojsa commented Jan 17, 2024

this has already been sent upstream. should this PR be closed for now?

Was it accepted already? If so, please sync this PULL so we can merge the driver

@kseerp
Copy link
Contributor Author

kseerp commented Jan 18, 2024

It's not yet accepted. I will follow up on it, once accepted, I'll update this PR and let you know. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants