fix(types): fix FileHeader types #987
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, this seems like a sensible fix, could you rebase it onto the v4 branch and run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
No issue, but I can create one if you'd like.
Description of changes:
I was looking at #708 when this was added, and several places in the code, but I don't see any reason this argument would be required as long as the provided function returns an array. And the tests don't seem to require it.
Happy to be proven wrong, but I think this would be a nice (albeit small) improvement for TS users. 馃槃
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.