chore: Improve propertySetup error handling #1023
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you rebase this to the v4 branch? the main/v3 branch is quite far behind at this point so I'm aiming to only backport really important bug or security fixes to it. This PR definitely seems useful, so I'll happily review and merge this to v4. You'll also need to update this test: |
| @@ -29,7 +29,7 @@ function propertySetup(property, name, path) { | |||
| if (!property && !_.isPlainObject(property)) | |||
| throw new Error('Property object must be an object'); | |||
| if (!name || !_.isString(name)) | |||
| throw new Error('Name must be a string'); | |||
| throw new Error('Name must be a string at path: ' + _.isArray(path) ? path.join('.') : path); | |||
There was a problem hiding this comment.
In v4 we're aiming to ditch lodash and es6 helpers, you can use native Array.isArray() instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
For bigger projects, its nearly impossible to locate the error, when an empty name is provided.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.