Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Migrate from node-sass to dart-sass #1019

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arnaud-ritti
Copy link

Description of changes:

Migrate from the deprecated node-sass to dart-sass

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@arnaud-ritti arnaud-ritti requested a review from a team as a code owner October 2, 2023 10:12
@notbear
Copy link

notbear commented Jan 16, 2024

Hi @dbanksdesign

Any chance for reviewing this in a predictable time? Would appreciate it a lot.

@jorenbroekema
Copy link
Collaborator

Hey, I actually migrated to dart-sass already in the v4 branch, which is released as a prerelease already.

Two questions:

  • Can you use the v4 prerelease for your use case? If not, can you explain why you need to have this change in v3, what exactly is making it blocking for you?
  • The cssEscape utility, can you explain what it does and why it's needed, and perhaps add some tests to document this? I don't have this part of your changes in the v4 branch yet, the rest of it (tests mostly) I do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants