CSharp Handle values with slashes #303
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ues with slashes "/". Append "\n" instead of using AppendLine, so it matches AWSSignerHelper.BuildStringToSign()
smargoli2
approved these changes
Feb 13, 2023
|
I noticed this issue as well! The unit tests do not pass because the generated strings do not match. |
Which unit test did not pass?
|
|
I tried to find it but could not remember which one it was, maybe I'll come back to this later...Sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing "Split path at / into segments" as the first step to handle values with slashes "/".
Append "\n" instead of using AppendLine, so it matches AWSSignerHelper.BuildStringToSign()