Test scroll #1119
Open
Test scroll #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests #1117
The test passes, but it passes even if we set
overflow: hiddenon thehtmltag instead. The issue has to do with settingheight: 100%onhtml, body, then settingoverflow: hiddenonhtml, body. Seems to only happen in Chrome as far as I could test. The unit tests don't also seem to include the default css files so maybe the modal code fork isn't even running?IS_DEFAULT_THEMEmight be false.Anyway, this is a start. At least it confirms the behaviour that we want.