Change amp-story-subscriptions attribute name to reflect its flexibil…

…ity (#38176)
ampproject · May 10, 2022 · 1a650fa · 1a650fa
1 parent 3fe2ae4
commit 1a650fa
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 16 deletions.
diff --git a/examples/amp-story/amp-story-subscriptions.html b/examples/amp-story/amp-story-subscriptions.html
@@ -229,9 +229,9 @@ <h3>Cultral Experiences</h3>
 
       <amp-story-subscriptions layout='container'
         price='$0.50/week'
-        title='Information at your fingertips'
-        subtitle-first='Subscribe for unlimited access.'
-        subtitle-second='Cancel anytime.'>
+        headline='Information at your fingertips'
+        description='Subscribe for unlimited access.'
+        additional-description='Cancel anytime.'>
       </amp-story-subscriptions>
     </amp-story>>
   </body>

diff --git a/examples/visual-tests/amp-story/amp-story-subscriptions.html b/examples/visual-tests/amp-story/amp-story-subscriptions.html
@@ -219,9 +219,9 @@ <h3>Cultral Experiences</h3>
 
       <amp-story-subscriptions layout='container'
         price='$0.50/week'
-        title='Information at your fingertips'
-        subtitle-first='Subscribe for unlimited access.'
-        subtitle-second='Cancel anytime.' publisher-button-text='Subscribe'>
+        headline='Information at your fingertips'
+        description='Subscribe for unlimited access.'
+        additional-description='Cancel anytime.'>
       </amp-story-subscriptions>
     </amp-story>>
   </body>

diff --git a/extensions/amp-story-subscriptions/0.1/amp-story-subscriptions.css b/extensions/amp-story-subscriptions/0.1/amp-story-subscriptions.css
@@ -142,7 +142,7 @@ iframe.swg-dialog {
   margin-bottom: 0.2em !important;
 }
 
-.i-amphtml-story-subscriptions-title {
+.i-amphtml-story-subscriptions-headline {
   display: block !important;
   font-weight: 700 !important;
   font-size: 1.15em !important;
@@ -152,7 +152,7 @@ iframe.swg-dialog {
   margin: 0.4em 0 0.15em !important;
 }
 
-.i-amphtml-story-subscriptions-subtitle-first, .i-amphtml-story-subscriptions-subtitle-second {
+.i-amphtml-story-subscriptions-description, .i-amphtml-story-subscriptions-additional-description {
   display: block !important;
   font-size: 0.9em !important;
   letter-spacing: -0.015em !important;

diff --git a/extensions/amp-story-subscriptions/0.1/amp-story-subscriptions.js b/extensions/amp-story-subscriptions/0.1/amp-story-subscriptions.js
@@ -222,17 +222,17 @@ export class AmpStorySubscriptions extends AMP.BaseElement {
           <span class="i-amphtml-story-subscriptions-price">
             {this.element.getAttribute('price')}
           </span>
-          {this.element.getAttribute('title') && (
-            <span class="i-amphtml-story-subscriptions-title">
-              {this.element.getAttribute('title')}
+          {this.element.getAttribute('headline') && (
+            <span class="i-amphtml-story-subscriptions-headline">
+              {this.element.getAttribute('headline')}
             </span>
           )}
-          <span class="i-amphtml-story-subscriptions-subtitle-first">
-            {this.element.getAttribute('subtitle-first')}
+          <span class="i-amphtml-story-subscriptions-description">
+            {this.element.getAttribute('description')}
           </span>
-          {this.element.getAttribute('subtitle-second') && (
-            <span class="i-amphtml-story-subscriptions-subtitle-second">
-              {this.element.getAttribute('subtitle-second')}
+          {this.element.getAttribute('additional-description') && (
+            <span class="i-amphtml-story-subscriptions-additional-description">
+              {this.element.getAttribute('additional-description')}
             </span>
           )}
           <button